Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-051 hide pool tab if not relevant #2189

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

andrewsparkes
Copy link
Member

Closes #2080

Changes proposed in this pull request

@andrewsparkes andrewsparkes self-assigned this Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (a5301c4) to head (e40a266).

Files with missing lines Patch % Lines
...models/presenters/minimal_stock_plate_presenter.rb 50.00% 1 Missing ⚠️
app/models/presenters/stock_plate_presenter.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2189   +/-   ##
========================================
  Coverage    80.81%   80.81%           
========================================
  Files          476      476           
  Lines        18212    18228   +16     
  Branches       269      269           
========================================
+ Hits         14718    14731   +13     
- Misses        3492     3495    +3     
  Partials         2        2           
Flag Coverage Δ
javascript 74.23% <ø> (ø)
pull_request 80.81% <88.23%> (+<0.01%) ⬆️
push 80.81% <88.23%> (+<0.01%) ⬆️
ruby 91.28% <88.23%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, definitely an improvement.
Thanks for the walk-through 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-051 [BUG] Limber can display an incorrect nonexistent pool and incorrect warnings for some stock plates.
2 participants